Skip to content

Bump GO to 1.19 #744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 2, 2022
Merged

Bump GO to 1.19 #744

merged 6 commits into from
Dec 2, 2022

Conversation

umbynos
Copy link
Contributor

@umbynos umbynos commented Dec 1, 2022 •
edited
Loading

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • Tests for the changes have been added (for bug fixes / features)
  • What kind of change does this PR introduce?

bump go

  • What is the current behavior?

We currently use an old version of GO in all our CI (1.14)

  • What is the new behavior?

GO 1.19

  • Does this PR introduce a breaking change?

no

  • Other information:

no

@umbynos umbynos changed the title Bump go Bump GO to 1.19 Dec 1, 2022
@umbynos umbynos self-assigned this Dec 1, 2022
@umbynos umbynos added type: enhancement Proposed improvement topic: code Related to content of the project itself topic: infrastructure Related to project infrastructure labels Dec 1, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2022 •
edited
Loading

Codecov Report

Base: 11.08% // Head: 11.08% // No change to project coverage 👍

Coverage data is based on head (4c1c946) compared to base (6257da8).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #744   +/-   ##
=======================================
  Coverage   11.08%   11.08%           
=======================================
  Files          50       50           
  Lines        3853     3853           
=======================================
  Hits          427      427           
  Misses       3372     3372           
  Partials       54       54
Flag Coverage Δ
unit 11.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
icon/iconlinux.go 0.00% <ø> (ø)
redirect_stderr_unix.go 0.00% <ø> (ø)
systray/systray_real.go 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@umbynos umbynos merged commit 64742a0 into main Dec 2, 2022
@umbynos umbynos deleted the bump-go branch December 2, 2022 14:01
@umbynos umbynos mentioned this pull request Dec 2, 2022
Closed
@per1234 per1234 mentioned this pull request Feb 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatteoPologruto MatteoPologruto MatteoPologruto approved these changes

@per1234 per1234 Awaiting requested review from per1234

Assignees

@umbynos umbynos

Labels
topic: code Related to content of the project itself topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@umbynos @codecov-commenter @MatteoPologruto